Metric instrumentation asgi #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
reviewed
Jul 20, 2022
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Show resolved
Hide resolved
lzchen
approved these changes
Jul 20, 2022
lzchen
requested changes
Jul 21, 2022
lzchen
reviewed
Jul 21, 2022
| self.assertEqual(len(data_points), 1) | ||
| for point in data_points: | ||
| if isinstance(point, HistogramDataPoint): | ||
| self.assertEqual(point.count, 3) |
There was a problem hiding this comment.
Can we test out the values?
There was a problem hiding this comment.
I see that the same test from the WSGI metrics instrumentation style is copied for writing tests everywhere. I would like to see the actual values as well with more tests.
There was a problem hiding this comment.
I've added test to check the attributes values. Please have a look.
There was a problem hiding this comment.
…nshul756/opentelemetry-python-contrib into metric-instrumentation-asgi
…python-contrib into metric-instrumentation-asgi
…nshul756/opentelemetry-python-contrib into metric-instrumentation-asgi
lzchen
approved these changes
Aug 2, 2022
srikanthccv
suggested changes
Aug 4, 2022
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py
Show resolved
Hide resolved
srikanthccv
approved these changes
Aug 8, 2022
shalevr
added a commit
to shalevr/opentelemetry-python-contrib
that referenced
this pull request
Aug 8, 2022
…hub.com/shalevr/opentelemetry-python-contrib into feature/Metrics-instrumentation-urllib3 * 'feature/Metrics-instrumentation-urllib3' of https://github.com/shalevr/opentelemetry-python-contrib: Metric instrumentation asgi (open-telemetry#1197) Metrics instrumentation flask (open-telemetry#1186) Adding sqlalchemy native tags in sqlalchemy commenter (open-telemetry#1206)
shalevr
added a commit
to shalevr/opentelemetry-python-contrib
that referenced
this pull request
Aug 30, 2022
* main: Codespell ci (open-telemetry#1237) aiohttp-client: Fix producing additional spans with each newly created ClientSession (open-telemetry#1246) Remove support for 3.6 (open-telemetry#853) Added the Licence and Manifest file Restore metrics in django (open-telemetry#1208) fix typo in example codes (open-telemetry#1240) boto3sqs: Make propagation compatible with other instrumentations and add 'messaging.url' span attribute (open-telemetry#1234) Release 1.12.0-0.33b0 (open-telemetry#1223) Fix Flask instrumentation doc link (open-telemetry#1216) Feature/metrics instrumentation urllib3 (open-telemetry#1198) Metric instrumentation asgi (open-telemetry#1197) Metrics instrumentation flask (open-telemetry#1186) Adding sqlalchemy native tags in sqlalchemy commenter (open-telemetry#1206) ci: fix docs workflow failure (open-telemetry#1211) Add psycopg2 native tags to sqlcommenter (open-telemetry#1203) SQLCommenter semicolon bug fix (open-telemetry#1200) Sync with sdk setup from setUpClass to setUp (open-telemetry#1193) # Conflicts: # CHANGELOG.md # instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py # instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1160
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e test-instrumentation-asgiDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.